feat: add disconnect account approval step #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euharrison
commented
Sep 12, 2024
| @@ -10,17 +10,12 @@ export const ApproveConnection: React.FC = () => { | |||
| const requester = useRequester(); | |||
| const params = useQuery(); | |||
| const interfaceOrigin = params.get("interfaceOrigin"); | |||
| const interfaceTabId = params.get("interfaceTabId"); | |||
There was a problem hiding this comment.
interfaceTabId wasn't used anymore, it was replaced by popupTabId directly on the service
| const resolver = this.getResolver(tabId); | ||
| if (resolver) { | ||
| resolver.reject(new Error("Window closed")); | ||
| this.removeResolver(tabId); |
There was a problem hiding this comment.
If the user closes the popup, it'll dispatch a message and clean the resolverMap
| return popupTabId; | ||
| }; | ||
|
|
||
| private launchApprovalPopup = async <T>( |
There was a problem hiding this comment.
launchApprovalPopup now combines the same pattern we have in all functions:
- Create the url
- Open the popup
- Return the resolver promise
- Plus: when the promise is resolved or rejected, it's also removed from the
resolverMap
euharrison
requested review from
jurevans,
mateuszjasiuk,
pedrorezende and
emccorson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the disconnection account approval step
This PR also combine e create some methods for the Approvals service to manage the popup easier, the main one is
launchApprovalPopupwhich takes a typed route and custom params. And it'll remove the popup resolver from the map once they are resolved or rejected, or when the popup is removed/closed by the userScreen.Recording.2024-09-12.at.19.37.00.mov